Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lesser drone nerfs #6140

Merged
merged 13 commits into from
Apr 20, 2024
Merged

Lesser drone nerfs #6140

merged 13 commits into from
Apr 20, 2024

Conversation

Git-Nivrak
Copy link
Contributor

@Git-Nivrak Git-Nivrak commented Apr 14, 2024

About the pull request

Explain why it's good for the game

Lesser drones can go for extremely high risk high reward strategies without any risk as there is basically an infinite amount of respawns and no punishment for dying.

I don't see why they should get a different treatment than huggers as they can just run in and apply facehuggers manually or for going off weeds to sneak into backline and place huggers on AFK marines they saw from ghost or just running around being an annoyance.

And this is coming from a xeno main.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: You can no longer infinitely extend facehugger's lifetime by REDACTED
balance: Lessers now lose 5 hp every 2 seconds off weeds
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Apr 14, 2024
@Drulikar Drulikar marked this pull request as draft April 14, 2024 20:16
@Git-Nivrak Git-Nivrak marked this pull request as ready for review April 15, 2024 15:40
@Drulikar Drulikar marked this pull request as draft April 15, 2024 18:40
@Git-Nivrak Git-Nivrak marked this pull request as ready for review April 15, 2024 19:16
@Drulikar Drulikar marked this pull request as draft April 16, 2024 18:11
@morrowwolf
Copy link
Member

None of the explanation here covers what you believe lesser drones should be. In a vacuum, this PR feels reasonable.

But it feels reasonable because there's zero context or actual design considerations here. This is a consistent theme across dozens of PRs that slowly but surely creep their way along to making something either useless, no longer interesting, or completely and totally different. The ancient open source trap of incremental changes where each step feels reasonable but then you look back and go, "How did we even get here?"

Moreover, why should facehuggers and lesser drones be considered under the same umbrella? An apple and an orange are both fruits but that doesn't mean an apple should have the same characteristics of an orange. And sure, facehuggers were stunned to avoid screech hugs right? And yes, lesser drones can go and do similar by just carrying a hugger. But, that doesn't encompass all that a lesser drone is. Extending this behavior means you should justify the behavior in the new total context.

https://en.wikipedia.org/wiki/Blind_men_and_an_elephant

Iunno, maybe this PR is good. Hard to say with how little justification is given and it genuinely reeks of salt PR.

@Git-Nivrak
Copy link
Contributor Author

Git-Nivrak commented Apr 18, 2024

None of the explanation here covers what you believe lesser drones should be. In a vacuum, this PR feels reasonable.

But it feels reasonable because there's zero context or actual design considerations here. This is a consistent theme across dozens of PRs that slowly but surely creep their way along to making something either useless, no longer interesting, or completely and totally different. The ancient open source trap of incremental changes where each step feels reasonable but then you look back and go, "How did we even get here?"

Moreover, why should facehuggers and lesser drones be considered under the same umbrella? An apple and an orange are both fruits but that doesn't mean an apple should have the same characteristics of an orange. And sure, facehuggers were stunned to avoid screech hugs right? And yes, lesser drones can go and do similar by just carrying a hugger. But, that doesn't encompass all that a lesser drone is. Extending this behavior means you should justify the behavior in the new total context.

https://en.wikipedia.org/wiki/Blind_men_and_an_elephant

Iunno, maybe this PR is good. Hard to say with how little justification is given and it genuinely reeks of salt PR.

Yea I am going to have to say that's one of the few times I actually agree with you however the reason I think they should get the same treatment as facehuggers (which is also stated in the PR description) is there being no cost \ punishment for them dying while having a lot of impact if they do succeed to facehug someone. Perhaps their cost \ cooldown can be modified in a way that killing them becomes significant and they can be allowed to go along with screeches but that's out of scope for this PR

@Git-Nivrak Git-Nivrak marked this pull request as ready for review April 18, 2024 11:28
@github-actions github-actions bot added the Fix Fix one bug, make ten more label Apr 18, 2024
@Drulikar Drulikar marked this pull request as draft April 19, 2024 21:55
This reverts commit 11bb36c.
This reverts commit 9bd02cd.
@Git-Nivrak Git-Nivrak marked this pull request as ready for review April 20, 2024 05:56
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Apr 20, 2024
@Drulikar Drulikar added this pull request to the merge queue Apr 20, 2024
Merged via the queue into cmss13-devs:master with commit 7679222 Apr 20, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Apr 20, 2024
@Skatuk
Copy link

Skatuk commented Apr 20, 2024

They could still bypass this since they can weed.

@Drulikar
Copy link
Contributor

They could still bypass this since they can weed.

They require weeds nearby to weed and have very low plasma. But yes we are completely aware the fact that weeds bypass the health decrease when not on weeds.

github-merge-queue bot pushed a commit that referenced this pull request Apr 24, 2024
# About the pull request

This PR is sort of a follow up to #6140 since it became obvious you
could soft-lock yourself in the hugger portion of the tutorial. Rather
than add more checks to prevent huggers deleting in tutorial, I instead
implemented handling when the hugger does die so you can still acquire
another hugger. The 30s deletion timer is still disabled for tutorial
huggers, but jump attempt deaths are possible.

# Explain why it's good for the game

Better replicates the hugger behavior in game, though still not 1-1 and
allows the tutorial to not be soft locked which could be very confusing
for a new player.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

https://youtu.be/9EBQNe2p4Sw

</details>


# Changelog
:cl: Drathek
fix: Fixed hugger handling in drone tutorial: Now the hugger dying will
put another hugger into the tutorial morpher.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants